Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Reconcile for owned resources" #189

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Revert "Reconcile for owned resources" #189

merged 1 commit into from
Oct 21, 2024

Conversation

assafad1
Copy link
Contributor

Reverts #180 which introduced race conditions between the controllers, and this raised the following error for alerts and outboundwebhooks:
the object has been modified; please apply your changes to the latest version and try again.

@assafad1 assafad1 requested a review from a team as a code owner October 20, 2024 18:24
Copy link
Contributor

Previous Coverage 26.8% of statements
New Coverage 27.0% of statements
Patch Coverage 63.2% of changed statements (12/19)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@assafad1 assafad1 closed this Oct 20, 2024
@assafad1 assafad1 reopened this Oct 21, 2024
@assafad1 assafad1 merged commit cb87680 into main Oct 21, 2024
14 of 16 checks passed
@assafad1 assafad1 deleted the revert-180-IAC-274 branch October 21, 2024 08:51
Copy link
Contributor

🎉 This PR is included in version 0.2.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants